Repository navigation
chore: remove dead code (closes #60) - #61
Merged
Merged
Conversation
- Delete orphan debug scripts: cli_test.py, cli_test_interactive.py (manual run-from-IDE entry points; not registered, not imported). - Delete src/fastled/install/test_install.py — unittest module never collected (test runner only scans tests/unit/) and never imported. - Remove Tools class from __init__.py — not in __all__, zero callers, only wraps a one-line string_diff import. - Remove CompileOrLink enum and _handle_ino_cpp helper from print_filter.py — both have zero references; PrintFilterDefault.filter returns text unchanged and never invokes the helper. safe_print() in emoji_util.py is intentionally retained: .cursorrules documents it as the recommended Unicode-safe print utility. Lint clean. Affected tests pass in isolation.
This was referenced May 12, 2026
zackees
added a commit
that referenced
this pull request
May 13, 2026
Sweeps the non-Python items issue #59 flagged that are still on main after PRs #61, #62, #64, #65, #66, #68 cleaned up the Python side: * `entrypoint.sh` — Docker container entrypoint. Sourced `/emsdk/emsdk_env.sh` (container path) and called `fastled_wasm_compiler.cli_update_from_master` (a module from a separate package that only exists inside the container). * `compiler/run.py` — Docker compile-server entry point. Imports `fastled_wasm_compiler`, a separate package not in this repo. * `compiler/debug.sh` — instructed user to run from `/js` (container working directory). Empty `compiler/` directory removed. * `.dockerignore` — only contained cache exclusions (`**/.mypy_cache/`, `**/.ruff_cache/`) which belong in `.gitignore` if anywhere; no Docker build context this could serve. * `chrome_vscode_bridge_design_task.md` — one-off design draft that opens with "Here's a refined ... file for your repo. Feel free to adjust...". Zero references anywhere else. * `upload_package.sh` — manual PyPI upload helper, superseded by the automated `publish_release.yml` workflow. Zero inbound references. * Empty root-level `fastled/` directory left over from a prior layout. `lint` script updated to stop passing the (now-deleted) `compiler/` path to ruff / black / isort / pyright / the keyboard-interrupt checker. `bash lint` clean. `bash test` — 119 pass. Verified by grep across `*.py`, `*.rs`, `*.toml`, `*.yml`, `*.sh`, `*.md`, `Cargo.toml` (excluding `.venv/` and `.claude/worktrees/`): none of the deleted files are referenced from a live code path or workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes confirmed dead code identified in #60. All items were verified by full-repo grep — zero references in
src/,tests/,.github/, scripts, or entry points.Deleted files
src/fastled/cli_test.py— manual debug script, not in entry points, not importedsrc/fastled/cli_test_interactive.py— same shapesrc/fastled/install/test_install.py— unittest module orphaned outsidetests/unit/; pytest never collects itDeleted symbols
Toolsclass insrc/fastled/__init__.py— not in__all__, zero callersCompileOrLinkenum insrc/fastled/print_filter.py— zero references_handle_ino_cpphelper insrc/fastled/print_filter.py— zero callersRetained
safe_print()insrc/fastled/emoji_util.py—.cursorrulesdocuments it as the recommended Unicode-safe print utility.Test plan
bash lint— clean (0 pyright errors / warnings)tests/unit/test_filechanger.pyflake under suite-load is pre-existing and unrelated to these changes)Closes #60
🤖 Generated with Claude Code